Skip to content

Completed "Add Task Killing to Linux and WinServer for LiDAR Dataprep" Epic

Paul Yarin requested to merge feature_task_killing into develop

I reworked the task-killer tests. Now, there are just two tests:

  1. A test workflow where a LASTool is run with a very small HangCheckInterval so that the LASTool should be killed (0.00001), the test checks that kill_report.txt has the correct output.
  2. A test workflow where a LASTools is run with a very large HangCheckInterval so that the LASTool should not be killed (100), the test checks that kill_report.txt is not created

Terry suggested changing task_killer.py to use the PID of the task to be killed instead of the task's name. This change did not end up being necessary, but I can make that change if I'm missing the reason for it.

I made changes so that task killing works on linux, and no changes were needed for task killing to work with WinServer.The pytest that I created passed on all platforms, and I manually checked that everything works as expected on all platforms (Orange/Windows 10, salbatch1/WinServer, the linux vm, and the vacc).

Merge request reports